From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12551 invoked by alias); 19 Jan 2005 21:41:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12508 invoked from network); 19 Jan 2005 21:41:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 19 Jan 2005 21:41:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j0JLfYFJ006335 for ; Wed, 19 Jan 2005 16:41:34 -0500 Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j0JLfWO23178; Wed, 19 Jan 2005 16:41:33 -0500 To: Daniel Jacobowitz Cc: Richard.Earnshaw@arm.com, Scott Bambrough , gdb-patches@sources.redhat.com Subject: Re: RFA: fix rdi-share subdir selection in configure References: <20050119204129.GA13535@nevyn.them.org> From: Jim Blandy Date: Wed, 19 Jan 2005 21:41:00 -0000 In-Reply-To: <20050119204129.GA13535@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-01/txt/msg00211.txt.bz2 Daniel Jacobowitz writes: > Two problems. > > On Wed, Jan 19, 2005 at 03:31:39PM -0500, Jim Blandy wrote: > > gdb_target=embed > > ! build_rdi_share=yes > > My mailer says you've got the whitespace disease. Hmm. I think I've fixed that. What's the rule? Just to leave what one found unchanged, or to always use tabs, or to never use tabs? > I don't think the netware target wants the ARM RDI protocol... I don't see why not. It's friendly enough --- and pretty in pink. 2005-01-19 Jim Blandy * configure.tgt: Set build_rdi_share to "yes" on those targets that use that debugging protocol. Set build_nlm to yes to build NLM stub for Netware targets. * configure.ac: If build_rdi_share is "yes", then configure the rdi-share subdirectory. If build_nlm is "yes", the configure the "nlm" subdirectory. * configure: Regenerated. Index: gdb/configure.tgt =================================================================== RCS file: /cvs/src/src/gdb/configure.tgt,v retrieving revision 1.157 diff -c -p -r1.157 configure.tgt *** gdb/configure.tgt 7 Jan 2005 16:22:33 -0000 1.157 --- gdb/configure.tgt 19 Jan 2005 21:33:34 -0000 *************** arm*-*-netbsd* | arm*-*-knetbsd*-gnu) *** 56,71 **** arm-*-nto*) gdb_target=nto ;; arm*-*-* | thumb*-*-* | strongarm*-*-*) gdb_target=embed ! # FIXME: cagney/2005-01-07: The configdirs ! # variable doesn't work with autoconf 2.59. ! # Disabled. ! # configdirs="$configdirs rdi-share" ;; xscale-*-*) gdb_target=embed ! # FIXME: cagney/2005-01-07: The configdirs ! # variable doesn't work with autoconf 2.59. ! # Disabled. ! # configdirs="$configdirs rdi-share" ;; avr-*-*) gdb_target=avr ;; --- 56,65 ---- arm-*-nto*) gdb_target=nto ;; arm*-*-* | thumb*-*-* | strongarm*-*-*) gdb_target=embed ! build_rdi_share=yes ;; xscale-*-*) gdb_target=embed ! build_rdi_share=yes ;; avr-*-*) gdb_target=avr ;; *************** i[34567]86-*-linux*) gdb_target=linux *** 96,105 **** ;; i[34567]86-*-gnu*) gdb_target=i386gnu ;; i[34567]86-*-netware*) gdb_target=i386 ! # FIXME: cagney/2005-01-07: The configdirs ! # variable doesn't work with autoconf 2.59. ! # Disabled. ! # configdirs="${configdirs} nlm" ;; i[34567]86-*-cygwin*) gdb_target=cygwin ;; i[34567]86-*-*) gdb_target=i386 ;; --- 90,96 ---- ;; i[34567]86-*-gnu*) gdb_target=i386gnu ;; i[34567]86-*-netware*) gdb_target=i386 ! build_nlm=yes ;; i[34567]86-*-cygwin*) gdb_target=cygwin ;; i[34567]86-*-*) gdb_target=i386 ;; Index: gdb/configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.3 diff -c -p -r1.3 configure.ac *** gdb/configure.ac 16 Jan 2005 22:51:49 -0000 1.3 --- gdb/configure.ac 19 Jan 2005 21:33:34 -0000 *************** if test "x$target" = "x$host"; then *** 1508,1513 **** --- 1508,1524 ---- fi fi + # We build rdi-share on ARM-based targets, as instructed by configure.tgt. + if test "x$build_rdi_share" = xyes; then + AC_CONFIG_SUBDIRS(rdi-share) + fi + + # We configure the nlm subdirectory on netware targets, as instructed + # by configure.tgt. + if test "x$build_nlm" = xyes; then + AC_CONFIG_SUBDIRS(nlm) + fi + # If hostfile (XM_FILE) and/or targetfile (DEPRECATED_TM_FILE) and/or # nativefile (NAT_FILE) is not set in config/*/*.m[ht] files, we link # to an empty version.