Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* PATCH: restore accidentally deleted call
@ 2003-04-11 19:01 Jim Blandy
  2003-04-11 20:14 ` Andrew Cagney
  0 siblings, 1 reply; 2+ messages in thread
From: Jim Blandy @ 2003-04-11 19:01 UTC (permalink / raw)
  To: gdb-patches


The call below was deleted in revision 1.88 of s390-tdep.c; inferior
calls broke because they didn't return to the call dummy breakpoint.
Since the ChangeLog entry only talks about deleting the gdbarch calls
to set CALL_DUMMY_START_OFFSET and CALL_DUMMY_LENGTH, I'm guessing
that was by accident.

2003-04-10  Jim Blandy  <jimb@redhat.com>

	* s390-tdep.c (s390_gdbarch_init): Put back accidentally deleted
	call to set_gdbarch_deprecated_push_arguments.

Index: s390-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/s390-tdep.c,v
retrieving revision 1.89
diff -c -r1.89 s390-tdep.c
*** s390-tdep.c	5 Apr 2003 18:54:38 -0000	1.89
--- s390-tdep.c	10 Apr 2003 22:26:56 -0000
***************
*** 1864,1869 ****
--- 1864,1871 ----
    set_gdbarch_deprecated_pc_in_call_dummy (gdbarch, deprecated_pc_in_call_dummy_at_entry_point);
    set_gdbarch_deprecated_push_arguments (gdbarch, s390_push_arguments);
    set_gdbarch_save_dummy_frame_tos (gdbarch, generic_save_dummy_frame_tos);
+   set_gdbarch_deprecated_push_return_address (gdbarch,
+                                               s390_push_return_address);
    set_gdbarch_sizeof_call_dummy_words (gdbarch,
                                         sizeof (s390_call_dummy_words));
    set_gdbarch_call_dummy_words (gdbarch, s390_call_dummy_words);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: restore accidentally deleted call
  2003-04-11 19:01 PATCH: restore accidentally deleted call Jim Blandy
@ 2003-04-11 20:14 ` Andrew Cagney
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2003-04-11 20:14 UTC (permalink / raw)
  To: Jim Blandy; +Cc: gdb-patches

> The call below was deleted in revision 1.88 of s390-tdep.c; inferior
> calls broke because they didn't return to the call dummy breakpoint.
> Since the ChangeLog entry only talks about deleting the gdbarch calls
> to set CALL_DUMMY_START_OFFSET and CALL_DUMMY_LENGTH, I'm guessing
> that was by accident.

More than likely from a merge botch.  Thanks for finding it.

> 2003-04-10  Jim Blandy  <jimb@redhat.com>
> 
> 	* s390-tdep.c (s390_gdbarch_init): Put back accidentally deleted
> 	call to set_gdbarch_deprecated_push_arguments.
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-04-11 20:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-11 19:01 PATCH: restore accidentally deleted call Jim Blandy
2003-04-11 20:14 ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox