Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: ac131313@redhat.com, carlton@kealia.com, fnasser@redhat.com,
	gdb-patches@sources.redhat.com
Subject: RFA: Don't include value of expression in pc-fp.exp test name
Date: Tue, 30 Sep 2003 06:44:00 -0000	[thread overview]
Message-ID: <vt2smmeok3g.fsf@zenia.home> (raw)
In-Reply-To: <200309291917.h8TJHLhn010447@duracef.shout.net>

Michael Elizabeth Chastain <mec@shout.net> writes:

> dc> What would make more of a difference for me (and,
> dc> presumably, for other people) would be to make it as easy as possible
> dc> to compare sum files: regularize the thread output a bit more, get rid
> dc> of gratuitous numbers (especially the value of $fp in pc-fp.exp).
> 
> I'm all for that.
> 
> Michael C

Like so?

2003-09-30  Jim Blandy  <jimb@redhat.com>

	* gdb.base/pc-fp.exp (get_valueofx): Don't include the value of
	the expression in the pass message.  This just creates spurious
	differences in summary files.

Index: gdb/testsuite/gdb.base/pc-fp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1
diff -c -r1.1 pc-fp.exp
*** gdb/testsuite/gdb.base/pc-fp.exp	25 Sep 2002 20:30:38 -0000	1.1
--- gdb/testsuite/gdb.base/pc-fp.exp	30 Sep 2003 06:39:50 -0000
***************
*** 62,68 ****
      gdb_expect {
  	-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
  	    set val $expect_out(1,string)
! 	    pass "get value of ${exp} ($val)"
  	}
  	timeout {
  	    set size ${default}
--- 62,68 ----
      gdb_expect {
  	-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
  	    set val $expect_out(1,string)
! 	    pass "get value of ${exp}"
  	}
  	timeout {
  	    set size ${default}


       reply	other threads:[~2003-09-30  6:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200309291917.h8TJHLhn010447@duracef.shout.net>
2003-09-30  6:44 ` Jim Blandy [this message]
2003-09-30 15:36   ` David Carlton
2003-09-30 17:49 Michael Elizabeth Chastain
2003-09-30 22:18 ` Jim Blandy
2003-10-01 15:31 ` Andrew Cagney
2003-10-01 15:49   ` David Carlton
2003-10-01  4:12 Michael Elizabeth Chastain
2003-10-01 16:44 Michael Elizabeth Chastain
2003-10-01 18:29 ` Andrew Cagney
2003-10-01 19:33   ` David Carlton
2003-10-01 19:06 Michael Elizabeth Chastain
2003-10-02 21:55 ` Andrew Cagney
2003-10-02 22:43 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2smmeok3g.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=carlton@kealia.com \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox