Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: carlton@kealia.com, fnasser@redhat.com,
	gdb-patches@sources.redhat.com, jimb@redhat.com
Subject: Re: RFA: Don't include value of expression in pc-fp.exp test name
Date: Thu, 02 Oct 2003 21:55:00 -0000	[thread overview]
Message-ID: <3F7C9EB3.7040306@redhat.com> (raw)
In-Reply-To: <200310011906.h91J6YlQ015766@duracef.shout.net>

> Andrew Cagney writes:
> 
>> Michael, you and I had an e-mail exchange about this very issue.  The 
>> end result, last time, was no change.
> 
> 
> Right.  You think there's a convention about "(...)",
> and I think there isn't.

The testsuite contains plenty of cases where the approach of putting 
suplemental information in paren has been used. "(timeout)" being the 
most obvious example.  Whether the convention or pratice or what ever 
has been used consistently, or uniformly, is of course a separate problem.

 >  Neither of us has changed our minds.

It is very important when an issue such as this re-emerges that all 
parties openly and transparently recognize there are differing opinions 
- "I think ..., but note that previously this wasn't resolved" - always 
be willing to raise the red flag so to speak.

The other thing is to not assume that people have closed minds.

> Fact: there are 1500+ test names with "(...)" in them.
> 
> Question: do you think these test names are written incorrectly?

I'll take that as retorical.

> If so, do you have any suggestions for alternate ways to rewrite
> test names such as: 
> 
>   # parentheses used for precedence
>   gdb.base/arithmet.exp: print x-(y+w)
>   gdb.base/arithmet.exp: print x/(y*w)
>   gdb.base/arithmet.exp: print x-(y/w)
>   gdb.base/arithmet.exp: print (x+y)*w

Now we're getting somewhere.  You've suggested /\/\/.*$/ as an 
alternative pattern.  Are there guidelines in the dejagnu doco?

Andrew



  reply	other threads:[~2003-10-02 21:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-01 19:06 Michael Elizabeth Chastain
2003-10-02 21:55 ` Andrew Cagney [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-10-02 22:43 Michael Elizabeth Chastain
2003-10-01 16:44 Michael Elizabeth Chastain
2003-10-01 18:29 ` Andrew Cagney
2003-10-01 19:33   ` David Carlton
2003-10-01  4:12 Michael Elizabeth Chastain
2003-09-30 17:49 Michael Elizabeth Chastain
2003-09-30 22:18 ` Jim Blandy
2003-10-01 15:31 ` Andrew Cagney
2003-10-01 15:49   ` David Carlton
     [not found] <200309291917.h8TJHLhn010447@duracef.shout.net>
2003-09-30  6:44 ` Jim Blandy
2003-09-30 15:36   ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F7C9EB3.7040306@redhat.com \
    --to=ac131313@redhat.com \
    --cc=carlton@kealia.com \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox