From: Jim Blandy <jimb@redhat.com>
To: Bryce McKinlay <mckinlay@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Patch: Handle relative paths in .debug_line
Date: Fri, 23 Jul 2004 21:13:00 -0000 [thread overview]
Message-ID: <vt2smbitoly.fsf@zenia.home> (raw)
In-Reply-To: <41004E5D.5020403@redhat.com>
Thanks for this patch!
In the revised dwarf2_start_subfile:
- It looks to me as if the new code doesn't handle the case where both
dirname and comp_dir are null.
- It seems to me that, when fullname == filename, the loop over the
subfiles duplicates the loop at the top of start_subfile. So that
loop should remain conditional. Its comment should be moved and
adjusted, too.
next prev parent reply other threads:[~2004-07-23 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-22 23:31 Bryce McKinlay
2004-07-23 21:13 ` Jim Blandy [this message]
2004-07-23 23:54 ` Bryce McKinlay
2004-07-29 20:19 ` Jim Blandy
2004-07-29 20:54 ` Bryce McKinlay
2004-07-31 4:16 ` Jim Blandy
2004-07-31 19:23 ` Bryce McKinlay
2004-07-31 20:51 ` Andrew Cagney
2004-08-01 0:24 ` Michael Chastain
2004-09-14 19:53 ` Andrew Cagney
2004-09-14 20:09 ` Bryce McKinlay
2004-09-24 19:12 ` Andrew Cagney
2004-09-30 0:40 Garrison
2004-09-30 0:49 ` Garrison
2004-10-01 18:23 ` Igor Kovalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2smbitoly.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mckinlay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox