From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10904 invoked by alias); 23 Jul 2004 21:13:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10896 invoked from network); 23 Jul 2004 21:13:06 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 23 Jul 2004 21:13:06 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6NLD6e1024270 for ; Fri, 23 Jul 2004 17:13:06 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6NLD4a21647; Fri, 23 Jul 2004 17:13:05 -0400 To: Bryce McKinlay Cc: gdb-patches@sources.redhat.com Subject: Re: Patch: Handle relative paths in .debug_line References: <41004E5D.5020403@redhat.com> From: Jim Blandy Date: Fri, 23 Jul 2004 21:13:00 -0000 In-Reply-To: <41004E5D.5020403@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-07/txt/msg00335.txt.bz2 Thanks for this patch! In the revised dwarf2_start_subfile: - It looks to me as if the new code doesn't handle the case where both dirname and comp_dir are null. - It seems to me that, when fullname == filename, the loop over the subfiles duplicates the loop at the top of start_subfile. So that loop should remain conditional. Its comment should be moved and adjusted, too.