From: Jim Blandy <jimb@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: RFA: use constructor to build 'struct regset' objects
Date: Thu, 20 May 2004 03:11:00 -0000 [thread overview]
Message-ID: <vt2pt8zzztd.fsf@zenia.home> (raw)
In-Reply-To: <40AB75A5.8030201@gnu.org>
Andrew Cagney <cagney@gnu.org> writes:
> > + struct regset *regset_xmalloc (void *descr,
> > + supply_regset_ftype *supply_regset,
> > + fill_regset_ftype *fill_regset)
> > + {
>
> Can you run the file through gdb_indent.sh?
I thought that looked odd. Thanks; this is fixed in the change I
committed.
> > + struct regset *r = (struct regset *) xmalloc (sizeof (*r));
>
> Since this data belongs to an architecture, this should be allocated
> From the architecture's obstack. I suspect this is a pre-existing
> bug but can you still fix it?
I'll take a look at it.
prev parent reply other threads:[~2004-05-20 3:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <vt2smdy93u9.fsf@zenia.home>
2004-05-17 21:32 ` Jim Blandy
2004-05-17 21:48 ` Mark Kettenis
2004-05-19 4:15 ` Jim Blandy
2004-05-19 8:36 ` kettenis
2004-05-20 3:11 ` Jim Blandy
2004-05-20 6:51 ` Jim Blandy
2004-05-19 14:56 ` Andrew Cagney
2004-05-20 3:11 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2pt8zzztd.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox