From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Blandy <jimb@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: RFA: use constructor to build 'struct regset' objects
Date: Thu, 20 May 2004 03:11:00 -0000
Message-id: <vt2pt8zzztd.fsf@zenia.home>
References: <vt2smdy93u9.fsf@zenia.home> <vt2iseu920y.fsf@zenia.home> <200405172148.i4HLm0bc014264@elgar.kettenis.dyndns.org> <vt2hdud2h0l.fsf@zenia.home> <40AB75A5.8030201@gnu.org>
X-SW-Source: 2004-05/msg00593.html

Andrew Cagney <cagney@gnu.org> writes:

> > + struct regset *regset_xmalloc (void *descr,
> > +                                supply_regset_ftype *supply_regset,
> > +                                fill_regset_ftype *fill_regset)
> > + {
> 
> Can you run the file through gdb_indent.sh?

I thought that looked odd.  Thanks; this is fixed in the change I
committed.

> > +   struct regset *r = (struct regset *) xmalloc (sizeof (*r));
> 
> Since this data belongs to an architecture, this should be allocated
> From the architecture's obstack.  I suspect this is a pre-existing
> bug but can you still fix it?

I'll take a look at it.