From: Jim Blandy <jimb@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/dwarf2] Small problem scanning line table for included files
Date: Wed, 28 Jul 2004 18:56:00 -0000 [thread overview]
Message-ID: <vt2oem0dksp.fsf@zenia.home> (raw)
In-Reply-To: <20040725151137.GT20596@gnat.com>
This is getting a bit hairy. It would be simpler to simply delete the
"!decode_for_pst_p && " towards the top of dwarf2_decode_lines, and
always create a psymtab for the first file. This could conceivably
result in creating psymtabs for source files that have no line number
entries in them, but that's probably not going to be a big deal.
(To be picky, we can make that mistake now anyway: consider what would
happen if the line number program contained two consecutive
DW_LNS_set_file instructions: the first file gets a psymtab, even
though it's never used.)
To get everything exactly right, we would need to delay setting a file
table entry's included_p flag until just before we actually call
record_line.
What do you think?
next prev parent reply other threads:[~2004-07-28 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-25 15:11 Joel Brobecker
2004-07-25 22:48 ` Michael Chastain
2004-07-28 18:56 ` Jim Blandy [this message]
2004-07-30 19:01 ` Joel Brobecker
2004-07-30 21:18 ` Joel Brobecker
2004-08-01 7:01 ` Jim Blandy
2004-08-02 1:26 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2oem0dksp.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox