From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20281 invoked by alias); 28 Jul 2004 18:56:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20274 invoked from network); 28 Jul 2004 18:56:22 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 28 Jul 2004 18:56:22 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6SIuMe1024577 for ; Wed, 28 Jul 2004 14:56:22 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6SIuKa20305; Wed, 28 Jul 2004 14:56:21 -0400 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf2] Small problem scanning line table for included files References: <20040725151137.GT20596@gnat.com> From: Jim Blandy Date: Wed, 28 Jul 2004 18:56:00 -0000 In-Reply-To: <20040725151137.GT20596@gnat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-07/txt/msg00426.txt.bz2 This is getting a bit hairy. It would be simpler to simply delete the "!decode_for_pst_p && " towards the top of dwarf2_decode_lines, and always create a psymtab for the first file. This could conceivably result in creating psymtabs for source files that have no line number entries in them, but that's probably not going to be a big deal. (To be picky, we can make that mistake now anyway: consider what would happen if the line number program contained two consecutive DW_LNS_set_file instructions: the first file gets a psymtab, even though it's never used.) To get everything exactly right, we would need to delay setting a file table entry's included_p flag until just before we actually call record_line. What do you think?