Re: [ppc64-linux]: specify size of long double on PPC64 Linux

[Jim Blandy <jimb@redhat.com>]

Kevin Buettner <kevinb@redhat.com> writes:

> On Jun 11,  2:50am, Jim Blandy wrote:
> 
> > 2003-06-11  Jim Blandy  <jimb@redhat.com>
> > 
> > 	* ppc-linux-tdep.c (ppc_linux_init_abi): long doubles are 16 bytes
> > 	long.
> > 
> > Index: gdb/ppc-linux-tdep.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/ppc-linux-tdep.c,v
> > retrieving revision 1.28.8.13
> > diff -c -r1.28.8.13 ppc-linux-tdep.c
> > *** gdb/ppc-linux-tdep.c	10 Jun 2003 18:00:30 -0000	1.28.8.13
> > --- gdb/ppc-linux-tdep.c	11 Jun 2003 06:43:41 -0000
> > ***************
> > *** 1027,1032 ****
> > --- 1027,1034 ----
> >     
> >     if (tdep->wordsize == 8)
> >       {
> > +       set_gdbarch_long_double_bit (gdbarch, 16 * TARGET_CHAR_BIT);
> > + 
> >         set_gdbarch_call_dummy_address (gdbarch, ppc64_call_dummy_address);
> >   
> >         set_gdbarch_in_solib_call_trampoline
> 
> Do you really need to do this?
> 
> rs6000-tdep.c already has the following in it:
> 
>   if (sysv_abi)
>     set_gdbarch_long_double_bit (gdbarch, 16 * TARGET_CHAR_BIT);
>   else
>     set_gdbarch_long_double_bit (gdbarch, 8 * TARGET_CHAR_BIT);
> 
> So, if I'm not mistaken, the size of long doubles should already be
> set correctly.

Ach, yes, I read that backwards.  Thanks for catching that.