From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-25184-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 28485 invoked by alias); 12 Jun 2003 21:00:37 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25678 invoked from network); 12 Jun 2003 20:59:42 -0000
Received: from unknown (HELO zenia.home) (12.223.225.216)
  by sources.redhat.com with SMTP; 12 Jun 2003 20:59:42 -0000
Received: by zenia.home (Postfix, from userid 5433)
	id D62C120D85; Thu, 12 Jun 2003 15:59:51 -0500 (EST)
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [ppc64-linux]: specify size of long double on PPC64 Linux
References: <vt2ptllt5m5.fsf@zenia.home>
	<1030611191816.ZM26256@localhost.localdomain>
From: Jim Blandy <jimb@redhat.com>
Date: Thu, 12 Jun 2003 21:00:00 -0000
In-Reply-To: <1030611191816.ZM26256@localhost.localdomain>
Message-ID: <vt2llw7t3js.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2003-06/txt/msg00428.txt.bz2

Kevin Buettner <kevinb@redhat.com> writes:

> On Jun 11,  2:50am, Jim Blandy wrote:
> 
> > 2003-06-11  Jim Blandy  <jimb@redhat.com>
> > 
> > 	* ppc-linux-tdep.c (ppc_linux_init_abi): long doubles are 16 bytes
> > 	long.
> > 
> > Index: gdb/ppc-linux-tdep.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/ppc-linux-tdep.c,v
> > retrieving revision 1.28.8.13
> > diff -c -r1.28.8.13 ppc-linux-tdep.c
> > *** gdb/ppc-linux-tdep.c	10 Jun 2003 18:00:30 -0000	1.28.8.13
> > --- gdb/ppc-linux-tdep.c	11 Jun 2003 06:43:41 -0000
> > ***************
> > *** 1027,1032 ****
> > --- 1027,1034 ----
> >     
> >     if (tdep->wordsize == 8)
> >       {
> > +       set_gdbarch_long_double_bit (gdbarch, 16 * TARGET_CHAR_BIT);
> > + 
> >         set_gdbarch_call_dummy_address (gdbarch, ppc64_call_dummy_address);
> >   
> >         set_gdbarch_in_solib_call_trampoline
> 
> Do you really need to do this?
> 
> rs6000-tdep.c already has the following in it:
> 
>   if (sysv_abi)
>     set_gdbarch_long_double_bit (gdbarch, 16 * TARGET_CHAR_BIT);
>   else
>     set_gdbarch_long_double_bit (gdbarch, 8 * TARGET_CHAR_BIT);
> 
> So, if I'm not mistaken, the size of long doubles should already be
> set correctly.

Ach, yes, I read that backwards.  Thanks for catching that.