From: Jim Blandy <jimb@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: PowerPC: add segment register numbers
Date: Thu, 15 Jul 2004 09:08:00 -0000 [thread overview]
Message-ID: <vt2llhlprqy.fsf@zenia.home> (raw)
In-Reply-To: <20040714172237.7f1e26b0@saguaro>
Kevin Buettner <kevinb@redhat.com> writes:
> A patch which does the latter would be welcome. Consider it preapproved.
I was writing this patch and noticed some odd code in rs6000_gdbarch_init:
/* Select instruction printer. */
if (arch == power)
set_gdbarch_print_insn (gdbarch, print_insn_rs6000);
else
set_gdbarch_print_insn (gdbarch, gdb_print_insn_powerpc);
Now, 'arch' is an enum, and 'power' is a boolean. So we've been using
gdb_print_insn_powerpc on rs6000 machines for some time --- the
incorrect code was introduced in r1.49, in Apr 2002.
So I'd like to actually try to test this patch on an RS6000 before
committing it. :)
next prev parent reply other threads:[~2004-07-15 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-12 22:10 Jim Blandy
2004-07-13 0:01 ` Kevin Buettner
2004-07-14 23:28 ` Jim Blandy
2004-07-15 0:22 ` Kevin Buettner
2004-07-15 9:08 ` Jim Blandy [this message]
2004-07-14 23:37 ` Jim Blandy
2004-07-15 0:23 ` Kevin Buettner
2004-07-15 8:48 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2llhlprqy.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox