From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12155 invoked by alias); 15 Jul 2004 09:08:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12144 invoked from network); 15 Jul 2004 09:08:08 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 15 Jul 2004 09:08:08 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6F988e1019659 for ; Thu, 15 Jul 2004 05:08:08 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6F987000426; Thu, 15 Jul 2004 05:08:07 -0400 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: PowerPC: add segment register numbers References: <20040712170129.47f4bc06@saguaro> <20040714172237.7f1e26b0@saguaro> From: Jim Blandy Date: Thu, 15 Jul 2004 09:08:00 -0000 In-Reply-To: <20040714172237.7f1e26b0@saguaro> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-07/txt/msg00183.txt.bz2 Kevin Buettner writes: > A patch which does the latter would be welcome. Consider it preapproved. I was writing this patch and noticed some odd code in rs6000_gdbarch_init: /* Select instruction printer. */ if (arch == power) set_gdbarch_print_insn (gdbarch, print_insn_rs6000); else set_gdbarch_print_insn (gdbarch, gdb_print_insn_powerpc); Now, 'arch' is an enum, and 'power' is a boolean. So we've been using gdb_print_insn_powerpc on rs6000 machines for some time --- the incorrect code was introduced in r1.49, in Apr 2002. So I'd like to actually try to test this patch on an RS6000 before committing it. :)