Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Julian Brown <julian@codesourcery.com>
Cc: gdb-patches@sourceware.org,  Daniel Jacobowitz <dan@codesourcery.com>
Subject: Re: [PATCH] Interpret DW_TAG_unspecified_type as void
Date: Tue, 13 Jun 2006 23:42:00 -0000	[thread overview]
Message-ID: <vt2lks062s8.fsf@theseus.home.> (raw)
In-Reply-To: <448969B2.9010202@codesourcery.com> (Julian Brown's message of "Fri, 09 Jun 2006 13:29:38 +0100")


Julian Brown <julian@codesourcery.com> writes:
> This is part of a series of patches from a CodeSourcery branch which
> enable the output of ARM's RVCT 2.2 compiler to be debugged with gdb.
>
> This patch handles the C/C++ interpretation of the DWARF 3 construct
> DW_TAG_unspecified_type as void. This is used in representing
> e.g. pointer-to-void types. Other languages will currently be handled
> in exactly the same way; though I'm not entirely sure if that's a
> sensible default, I don't know what would be better. (Re: section 5.2
> of the DWARF 3 doc.)
>
> Tested natively on x86_64-unknown-linux-gnu and cross to arm-none-eabi
> with no change in results. Tests against the ARM compiler are improved
> somewhat.
>
> OK to apply?

Yes, this looks fine --- thanks!

If the change was written by Daniel, and you're merging it on his
behalf, I think our practice is to use a ChangeLog entry like this:

2006-06-12  Daniel Jacobowitz  <dan@codesourcery.com>

	* dwarf2read.c (read_unspecified_type): New function.
	(read_type_die): Handle DW_TAG_unspecified_type.
        (Committed by Julian Brown.)


  reply	other threads:[~2006-06-13 23:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-09 12:32 Julian Brown
2006-06-13 23:42 ` Jim Blandy [this message]
2006-06-13 23:47   ` Daniel Jacobowitz
2006-06-18  1:16 ` Mark Kettenis
2006-06-19 12:58   ` Richard Earnshaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2lks062s8.fsf@theseus.home. \
    --to=jimb@codesourcery.com \
    --cc=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=julian@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox