From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11327 invoked by alias); 13 Jun 2006 23:42:36 -0000 Received: (qmail 11317 invoked by uid 22791); 13 Jun 2006 23:42:34 -0000 X-Spam-Check-By: sourceware.org Received: from potter.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Jun 2006 23:42:33 +0000 Received: (qmail 23569 invoked from network); 13 Jun 2006 23:42:32 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Jun 2006 23:42:32 -0000 To: Julian Brown Cc: gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [PATCH] Interpret DW_TAG_unspecified_type as void References: <448969B2.9010202@codesourcery.com> From: Jim Blandy Date: Tue, 13 Jun 2006 23:42:00 -0000 In-Reply-To: <448969B2.9010202@codesourcery.com> (Julian Brown's message of "Fri, 09 Jun 2006 13:29:38 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00206.txt.bz2 Julian Brown writes: > This is part of a series of patches from a CodeSourcery branch which > enable the output of ARM's RVCT 2.2 compiler to be debugged with gdb. > > This patch handles the C/C++ interpretation of the DWARF 3 construct > DW_TAG_unspecified_type as void. This is used in representing > e.g. pointer-to-void types. Other languages will currently be handled > in exactly the same way; though I'm not entirely sure if that's a > sensible default, I don't know what would be better. (Re: section 5.2 > of the DWARF 3 doc.) > > Tested natively on x86_64-unknown-linux-gnu and cross to arm-none-eabi > with no change in results. Tests against the ARM compiler are improved > somewhat. > > OK to apply? Yes, this looks fine --- thanks! If the change was written by Daniel, and you're merging it on his behalf, I think our practice is to use a ChangeLog entry like this: 2006-06-12 Daniel Jacobowitz * dwarf2read.c (read_unspecified_type): New function. (read_type_die): Handle DW_TAG_unspecified_type. (Committed by Julian Brown.)