Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: gdb.base/auxv.exp: 'untested' instead of gdb_suppress_entire_file
Date: Mon, 02 May 2005 19:13:00 -0000	[thread overview]
Message-ID: <vt2hdhle95k.fsf@zenia.home> (raw)


Looking at this message:
http://sourceware.org/ml/gdb-patches/2005-04/msg00143.html

I gather that changes like the below are welcome --- right?

2005-05-02  Jim Blandy  <jimb@redhat.com>

	* gdb.base/auxv.exp: Call 'untested' and return -1 instead of
	calling gdb_suppress_entire_file.

Index: gdb/testsuite/gdb.base/auxv.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/auxv.exp,v
retrieving revision 1.1
diff -c -p -r1.1 auxv.exp
*** gdb/testsuite/gdb.base/auxv.exp	13 Apr 2004 16:39:08 -0000	1.1
--- gdb/testsuite/gdb.base/auxv.exp	2 May 2005 19:08:09 -0000
*************** set corefile ${objdir}/${subdir}/${testf
*** 37,43 ****
  set gcorefile ${objdir}/${subdir}/${testfile}.gcore
  
  if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
!      gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
  }
  
  # Use a fresh directory to confine the native core dumps.
--- 37,44 ----
  set gcorefile ${objdir}/${subdir}/${testfile}.gcore
  
  if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
!     untested "couldn't compile ${srcdir}/${subdir}/${srcfile}"
!     return -1
  }
  
  # Use a fresh directory to confine the native core dumps.


             reply	other threads:[~2005-05-02 19:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-02 19:13 Jim Blandy [this message]
2005-05-02 19:14 ` Daniel Jacobowitz
2005-05-02 21:00   ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2hdhle95k.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox