From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39152-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 17407 invoked by alias); 2 May 2005 19:13:19 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 17203 invoked from network); 2 May 2005 19:13:12 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 2 May 2005 19:13:12 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j42JDCrS007552
	for <gdb-patches@sources.redhat.com>; Mon, 2 May 2005 15:13:12 -0400
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j42JDBO09774;
	Mon, 2 May 2005 15:13:12 -0400
To: gdb-patches@sources.redhat.com
Subject: RFA: gdb.base/auxv.exp: 'untested' instead of gdb_suppress_entire_file
From: Jim Blandy <jimb@redhat.com>
Date: Mon, 02 May 2005 19:13:00 -0000
Message-ID: <vt2hdhle95k.fsf@zenia.home>
User-Agent: Gnus/5.090 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2005-05/txt/msg00055.txt.bz2


Looking at this message:
http://sourceware.org/ml/gdb-patches/2005-04/msg00143.html

I gather that changes like the below are welcome --- right?

2005-05-02  Jim Blandy  <jimb@redhat.com>

	* gdb.base/auxv.exp: Call 'untested' and return -1 instead of
	calling gdb_suppress_entire_file.

Index: gdb/testsuite/gdb.base/auxv.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/auxv.exp,v
retrieving revision 1.1
diff -c -p -r1.1 auxv.exp
*** gdb/testsuite/gdb.base/auxv.exp	13 Apr 2004 16:39:08 -0000	1.1
--- gdb/testsuite/gdb.base/auxv.exp	2 May 2005 19:08:09 -0000
*************** set corefile ${objdir}/${subdir}/${testf
*** 37,43 ****
  set gcorefile ${objdir}/${subdir}/${testfile}.gcore
  
  if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
!      gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
  }
  
  # Use a fresh directory to confine the native core dumps.
--- 37,44 ----
  set gcorefile ${objdir}/${subdir}/${testfile}.gcore
  
  if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
!     untested "couldn't compile ${srcdir}/${subdir}/${srcfile}"
!     return -1
  }
  
  # Use a fresh directory to confine the native core dumps.