Re: RFA: patch to fix gdb/1680

[Jim Blandy <jimb@redhat.com>]

Andreas Schwab <schwab@suse.de> writes:

> Jim Blandy <jimb@redhat.com> writes:
> 
> > Ahh.  Here is a revision of my patch.  It is tested under the same
> > configuration as the original patch.
> >
> > 2004-06-17  Jim Blandy  <jimb@redhat.com>
> >
> >         Fix PR testsuite/1680.
> > 	* gdb.arch/i386-sse.exp: Don't use curly braces in regular
> > 	expressions.
> 
> How about "Quote curly braces in regular expressions"?

But that would describe my patch correctly.  Whose side are you on,
anyway?

(Thanks for noticing this; corrected as suggested.  And thanks to
Michael, too.)

2004-06-17  Jim Blandy  <jimb@redhat.com>

        Fix PR testsuite/1680.
	* gdb.arch/i386-sse.exp: Properly quote curly braces in
	regular expressions.

Index: gdb/testsuite/gdb.arch/i386-sse.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-sse.exp,v
retrieving revision 1.1
diff -c -p -r1.1 i386-sse.exp
*** gdb/testsuite/gdb.arch/i386-sse.exp	7 Jun 2004 15:38:52 -0000	1.1
--- gdb/testsuite/gdb.arch/i386-sse.exp	18 Jun 2004 22:15:52 -0000
*************** gdb_continue_to_breakpoint "continue to 
*** 71,77 ****
  
  foreach r {0 1 2 3 4 5 6 7} {
      gdb_test "print \$xmm$r.v4_float" \
!         ".. = {$r, $r.25, $r.5, $r.75}.*" \
          "check contents of %xmm$r"
  }
  
--- 71,77 ----
  
  foreach r {0 1 2 3 4 5 6 7} {
      gdb_test "print \$xmm$r.v4_float" \
!         ".. = \\{$r, $r.25, $r.5, $r.75\\}.*" \
          "check contents of %xmm$r"
  }
  
*************** gdb_continue_to_breakpoint "continue to 
*** 86,91 ****
  
  foreach r {0 1 2 3 4 5 6 7} {
      gdb_test "print data\[$r\]" \
!         ".. = {f = {[expr $r + 10], $r.25, $r.5, $r.75}}.*" \
          "check contents of data\[$r\]"
  }
--- 86,91 ----
  
  foreach r {0 1 2 3 4 5 6 7} {
      gdb_test "print data\[$r\]" \
!         ".. = \\{f = \\{[expr $r + 10], $r.25, $r.5, $r.75\\}\\}.*" \
          "check contents of data\[$r\]"
  }