From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-33965-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 31873 invoked by alias); 19 Jun 2004 06:15:19 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 31866 invoked from network); 19 Jun 2004 06:15:19 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 19 Jun 2004 06:15:19 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5J6FIe3010170
	for <gdb-patches@sources.redhat.com>; Sat, 19 Jun 2004 02:15:18 -0400
Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5J6FF023175;
	Sat, 19 Jun 2004 02:15:16 -0400
To: Andreas Schwab <schwab@suse.de>
Cc: Daniel Jacobowitz <drow@false.org>,
        Michael Elizabeth Chastain <mec.gnu@mindspring.com>,
        gdb-patches@sources.redhat.com, Keith Seitz <keiths@redhat.com>,
        Andrew Cagney <cagney@gnu.org>
Subject: Re: RFA: patch to fix gdb/1680
References: <20040618191836.629204B104@berman.michael-chastain.com>
	<20040618194250.GA28102@nevyn.them.org> <vt27ju4tso7.fsf@zenia.home>
	<jeekocfpke.fsf@sykes.suse.de>
From: Jim Blandy <jimb@redhat.com>
Date: Sat, 19 Jun 2004 06:15:00 -0000
In-Reply-To: <jeekocfpke.fsf@sykes.suse.de>
Message-ID: <vt2ekocrs4h.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-06/txt/msg00457.txt.bz2

Andreas Schwab <schwab@suse.de> writes:

> Jim Blandy <jimb@redhat.com> writes:
> 
> > Ahh.  Here is a revision of my patch.  It is tested under the same
> > configuration as the original patch.
> >
> > 2004-06-17  Jim Blandy  <jimb@redhat.com>
> >
> >         Fix PR testsuite/1680.
> > 	* gdb.arch/i386-sse.exp: Don't use curly braces in regular
> > 	expressions.
> 
> How about "Quote curly braces in regular expressions"?

But that would describe my patch correctly.  Whose side are you on,
anyway?

(Thanks for noticing this; corrected as suggested.  And thanks to
Michael, too.)

2004-06-17  Jim Blandy  <jimb@redhat.com>

        Fix PR testsuite/1680.
	* gdb.arch/i386-sse.exp: Properly quote curly braces in
	regular expressions.

Index: gdb/testsuite/gdb.arch/i386-sse.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-sse.exp,v
retrieving revision 1.1
diff -c -p -r1.1 i386-sse.exp
*** gdb/testsuite/gdb.arch/i386-sse.exp	7 Jun 2004 15:38:52 -0000	1.1
--- gdb/testsuite/gdb.arch/i386-sse.exp	18 Jun 2004 22:15:52 -0000
*************** gdb_continue_to_breakpoint "continue to 
*** 71,77 ****
  
  foreach r {0 1 2 3 4 5 6 7} {
      gdb_test "print \$xmm$r.v4_float" \
!         ".. = {$r, $r.25, $r.5, $r.75}.*" \
          "check contents of %xmm$r"
  }
  
--- 71,77 ----
  
  foreach r {0 1 2 3 4 5 6 7} {
      gdb_test "print \$xmm$r.v4_float" \
!         ".. = \\{$r, $r.25, $r.5, $r.75\\}.*" \
          "check contents of %xmm$r"
  }
  
*************** gdb_continue_to_breakpoint "continue to 
*** 86,91 ****
  
  foreach r {0 1 2 3 4 5 6 7} {
      gdb_test "print data\[$r\]" \
!         ".. = {f = {[expr $r + 10], $r.25, $r.5, $r.75}}.*" \
          "check contents of data\[$r\]"
  }
--- 86,91 ----
  
  foreach r {0 1 2 3 4 5 6 7} {
      gdb_test "print data\[$r\]" \
!         ".. = \\{f = \\{[expr $r + 10], $r.25, $r.5, $r.75\\}\\}.*" \
          "check contents of data\[$r\]"
  }