Re: [rfa/dwarf] Use objfile_data mechanism for per-objfile data

[Jim Blandy <jimb@redhat.com>]

Daniel Jacobowitz <drow@false.org> writes:
> - 'dwarf2_objfile_data_key' for the 'struct objfile_data', and
> - 'struct dwarf2_per_objfile' for the struct
> - 'dwarf2_per_objfile' for the global
> 
> Sound good?

Okay.


> > > > The lower-case implicit-parameter macros bug me.  But I assume they're
> > > > going away soon, and upper-casing them would make the patch huge,
> > > > right?
> > > 
> > > I didn't have a particular plan in either direction.  Doing either
> > > would be an easy follow-on.  Replacing them with their expansions would
> > > be noisy indentation-wise, but otherwise trivial - that may be best.
> > 
> > I'd be happier with replacing them with their expansions.  We could
> > drop the 'dwarf_' prefixes on the member names, too.
> 
> OK.  Mind if I do this later, i.e. in a few weeks?  I'm polishing the
> rest of the intercu patches for submission now.
> 
> If you have a strong preference I can do it now instead.

If they sit there for very long, I will have neglected my duties.  But
you've been working steadily on this for quite a while, so short of
some disaster for you, I'm confident it'll get done.  So if it would
produce interference with your other patches, leave it for later.