Re: [rfa/dwarf] Use objfile_data mechanism for per-objfile data

[Daniel Jacobowitz <drow@false.org>]

On Thu, Apr 01, 2004 at 04:57:11PM -0500, Jim Blandy wrote:
> 
> Daniel Jacobowitz <drow@false.org> writes:
> > > How about:
> > > - 'dwarf2_objfile_data_key' for the 'struct objfile_data', and
> > > - 'struct dwarf2_objfile' and 'dwarf2_objfile' for the actual
> > >   per-objfile datatype and the global pointer to the current instance?
> > > 
> > > (Is that any better?  I think suffixes like "_data" really only belong
> > > on things whose type is unspecified at the point where the name
> > > appears, like 'void *' pointers, or objects related to them.  I mean,
> > > everything is "data"; if you're going to give something a
> > > generic-sounding name, that should be because you're emphasizing the
> > > genericness of it.)
> > 
> > I don't think that's any better.  "dwarf2_objfile" implies that it's a
> > kind of objfile.  But I'm willing to use your names :)
> 
> No, no: "We striev for kwalitie."
> 
> Okay, well, how about 'struct dwarf2_per_objfile' and
> dwarf2_per_objfile'?  That's pretty close to your original names.

- 'dwarf2_objfile_data_key' for the 'struct objfile_data', and
- 'struct dwarf2_per_objfile' for the struct
- 'dwarf2_per_objfile' for the global

Sound good?

> > > The lower-case implicit-parameter macros bug me.  But I assume they're
> > > going away soon, and upper-casing them would make the patch huge,
> > > right?
> > 
> > I didn't have a particular plan in either direction.  Doing either
> > would be an easy follow-on.  Replacing them with their expansions would
> > be noisy indentation-wise, but otherwise trivial - that may be best.
> 
> I'd be happier with replacing them with their expansions.  We could
> drop the 'dwarf_' prefixes on the member names, too.

OK.  Mind if I do this later, i.e. in a few weeks?  I'm polishing the
rest of the intercu patches for submission now.

If you have a strong preference I can do it now instead.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer