From: Jim Blandy <jimb@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: Daniel Jacobowitz <drow@false.org>,
Elena Zannoni <ezannoni@redhat.com>,
gdb-patches@sources.redhat.com
Subject: Re: [RFA/dwarf-2] Fix for the null record problem
Date: Thu, 15 Apr 2004 05:33:00 -0000 [thread overview]
Message-ID: <vt265c16c56.fsf@zenia.home> (raw)
In-Reply-To: <20040414174729.GA612@nevyn.them.org>
Actually, I just realized: it's incorrect to write
if (dwarf2_attr (die, DW_AT_declaration, cu)) ...;
when you want to do ... when die is a declaration. As with any flag
attribute, you must write:
decl_attr = dwarf2_attr (die, DW_AT_declaration, cu);
if (decl_attr && DW_UNSND (decl_attr)) ...;
(It might not be bad to add a function 'attribute_true_p (DIE, ATTR)'
that captures this logic, because it's used a lot. But that should be
a separate cleanup; don't feel obliged.)
next prev parent reply other threads:[~2004-04-15 5:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-19 14:01 Joel Brobecker
2004-02-19 21:52 ` Elena Zannoni
2004-02-19 23:29 ` Andrew Cagney
2004-02-19 23:37 ` Joel Brobecker
2004-02-26 2:31 ` Joel Brobecker
2004-02-26 3:27 ` Daniel Jacobowitz
2004-02-26 19:00 ` Joel Brobecker
2004-04-01 1:18 ` Joel Brobecker
2004-04-13 5:26 ` Joel Brobecker
2004-04-14 17:24 ` Jim Blandy
2004-04-14 17:47 ` Daniel Jacobowitz
2004-04-15 5:01 ` Jim Blandy
2004-04-15 20:43 ` Joel Brobecker
2004-04-16 3:18 ` Joel Brobecker
2004-04-16 3:59 ` Jim Blandy
2004-04-15 5:33 ` Jim Blandy [this message]
2004-02-26 19:49 Michael Elizabeth Chastain
2004-02-26 20:23 ` Joel Brobecker
2004-02-26 21:34 Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt265c16c56.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=brobecker@gnat.com \
--cc=drow@false.org \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox