From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25193 invoked by alias); 15 Apr 2004 05:33:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25177 invoked from network); 15 Apr 2004 05:33:38 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 15 Apr 2004 05:33:38 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3F5Xcu6012667 for ; Thu, 15 Apr 2004 01:33:38 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3F5Xaj13470; Thu, 15 Apr 2004 01:33:37 -0400 To: Joel Brobecker Cc: Daniel Jacobowitz , Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf-2] Fix for the null record problem References: <20040219140145.GB804@gnat.com> <16437.11835.435941.553479@localhost.redhat.com> <20040401011813.GE888@gnat.com> <20040413052655.GB1173@gnat.com> <20040414174729.GA612@nevyn.them.org> From: Jim Blandy Date: Thu, 15 Apr 2004 05:33:00 -0000 In-Reply-To: <20040414174729.GA612@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-04/txt/msg00297.txt.bz2 Actually, I just realized: it's incorrect to write if (dwarf2_attr (die, DW_AT_declaration, cu)) ...; when you want to do ... when die is a declaration. As with any flag attribute, you must write: decl_attr = dwarf2_attr (die, DW_AT_declaration, cu); if (decl_attr && DW_UNSND (decl_attr)) ...; (It might not be bad to add a function 'attribute_true_p (DIE, ATTR)' that captures this logic, because it's used a lot. But that should be a separate cleanup; don't feel obliged.)