Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: ezannoni@redhat.com, gdb-patches@sources.redhat.com, ac131313@redhat.com
Subject: Re: [rfa/symtab] array bounds, int -> enum
Date: Fri, 22 Aug 2003 03:41:00 -0000	[thread overview]
Message-ID: <vt24r0as6ia.fsf@zenia.home> (raw)
In-Reply-To: <200308212234.h7LMYuAF000490@duracef.shout.net>


Michael Elizabeth Chastain <mec@shout.net> writes:
> I removed the FIXME because it is a bad idea.  Code in valops.c and
> varobj.c, among other places, check the bound type (although they do it
> trivially).  I don't see any language specifier in main_type; the
> language is over in the symbol code, not in the type code.  So it would
> be difficult, and probably useless, to make all code that looks at array
> bound types check whether the type is a "FORTRAN type" or not before
> looking at the array bounds.  Just use appropriate bound types for all
> array symbols in all languages and be done with it.

I think deleting the FIXME is fine.

If one were going to do that, one would indicate whether they applied
by splitting TYPE_CODE_ARRAY into TYPE_CODE_ARRAY and
TYPE_CODE_FORTRAN_ARRAY, or something --- that is, let the
discriminant say which fields are present / meaningful.  But we don't
really do that, so it's not worth it.

> Testing: the usual drill, native i686-pc-linux-gnu, gcc v2 and v3,
> dwarf-2 and stabs+.
> 
> Okay to apply?

Yes, please do.


  reply	other threads:[~2003-08-22  3:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-21 22:35 Michael Elizabeth Chastain
2003-08-22  3:41 ` Jim Blandy [this message]
2003-08-22  5:07 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt24r0as6ia.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox