From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20921 invoked by alias); 22 Aug 2003 03:41:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20914 invoked from network); 22 Aug 2003 03:41:10 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 22 Aug 2003 03:41:10 -0000 Received: by zenia.home (Postfix, from userid 5433) id 8B6F0202C8; Thu, 21 Aug 2003 22:42:05 -0500 (EST) To: Michael Elizabeth Chastain Cc: ezannoni@redhat.com, gdb-patches@sources.redhat.com, ac131313@redhat.com Subject: Re: [rfa/symtab] array bounds, int -> enum References: <200308212234.h7LMYuAF000490@duracef.shout.net> From: Jim Blandy Date: Fri, 22 Aug 2003 03:41:00 -0000 In-Reply-To: <200308212234.h7LMYuAF000490@duracef.shout.net> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-08/txt/msg00385.txt.bz2 Michael Elizabeth Chastain writes: > I removed the FIXME because it is a bad idea. Code in valops.c and > varobj.c, among other places, check the bound type (although they do it > trivially). I don't see any language specifier in main_type; the > language is over in the symbol code, not in the type code. So it would > be difficult, and probably useless, to make all code that looks at array > bound types check whether the type is a "FORTRAN type" or not before > looking at the array bounds. Just use appropriate bound types for all > array symbols in all languages and be done with it. I think deleting the FIXME is fine. If one were going to do that, one would indicate whether they applied by splitting TYPE_CODE_ARRAY into TYPE_CODE_ARRAY and TYPE_CODE_FORTRAN_ARRAY, or something --- that is, let the discriminant say which fields are present / meaningful. But we don't really do that, so it's not worth it. > Testing: the usual drill, native i686-pc-linux-gnu, gcc v2 and v3, > dwarf-2 and stabs+. > > Okay to apply? Yes, please do.