* Re: RFA: remove meaningless code in ppc-bdm.c
[not found] <vt2pt9bvr42.fsf@zenia.home>
@ 2004-05-11 5:38 ` Kevin Buettner
2004-05-11 6:13 ` Jim Blandy
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Buettner @ 2004-05-11 5:38 UTC (permalink / raw)
To: Jim Blandy; +Cc: gdb-patches
On 10 May 2004 17:45:17 -0500
Jim Blandy <jimb@redhat.com> wrote:
> I was going through this trying to keep it up to date with the
> register numbering changes I was making, but then I realized it was
> complete jibberish. First, the register contents are binary data; you
> can't strcat them. Second, you can't strcat them into a fixed-size
> buffer that is already filled with non-zero bytes.
>
> 2004-05-10 Jim Blandy <jimb@redhat.com>
>
> * ppc-bdm.c (bdm_ppc_fetch_registers): Replace utterly broken code
> with a call to internal_error.
Okay.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: RFA: remove meaningless code in ppc-bdm.c
2004-05-11 5:38 ` RFA: remove meaningless code in ppc-bdm.c Kevin Buettner
@ 2004-05-11 6:13 ` Jim Blandy
0 siblings, 0 replies; 2+ messages in thread
From: Jim Blandy @ 2004-05-11 6:13 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
Kevin Buettner <kevinb@redhat.com> writes:
> On 10 May 2004 17:45:17 -0500
> Jim Blandy <jimb@redhat.com> wrote:
>
> > I was going through this trying to keep it up to date with the
> > register numbering changes I was making, but then I realized it was
> > complete jibberish. First, the register contents are binary data; you
> > can't strcat them. Second, you can't strcat them into a fixed-size
> > buffer that is already filled with non-zero bytes.
> >
> > 2004-05-10 Jim Blandy <jimb@redhat.com>
> >
> > * ppc-bdm.c (bdm_ppc_fetch_registers): Replace utterly broken code
> > with a call to internal_error.
>
> Okay.
Committed, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-05-11 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <vt2pt9bvr42.fsf@zenia.home>
2004-05-11 5:38 ` RFA: remove meaningless code in ppc-bdm.c Kevin Buettner
2004-05-11 6:13 ` Jim Blandy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox