Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: Misapplied patch to _initialize_gdb_osabi?
Date: Mon, 03 Nov 2003 22:09:00 -0000	[thread overview]
Message-ID: <vt21xspumte.fsf@zenia.home> (raw)


CVS says that revision 1.17 to gdb/osabi.c (ChangeLog entry attached)
made the following change:

2003-08-24  Andrew Cagney  <cagney@redhat.com>

	* arm-tdep.c (_initialize_arm_tdep): Simplify by assuming
	GDB_MULTI_ARCH is always non-zero.
	* osabi.c (_initialize_gdb_osabi): Ditto.
	(gdbarch_init_osabi): Ditto.
	* sparc-tdep.c: Ditto for #if code.

***************
*** 571,578 ****
  				  bfd_target_elf_flavour,
  				  generic_elf_osabi_sniffer);
  
!   if (!GDB_MULTI_ARCH)
!     return;
  
    /* Register the "set osabi" command.  */
    c = add_set_enum_cmd ("osabi", class_support, gdb_osabi_available_names,
--- 567,573 ----
  				  bfd_target_elf_flavour,
  				  generic_elf_osabi_sniffer);
  
!   return;
  
    /* Register the "set osabi" command.  */
    c = add_set_enum_cmd ("osabi", class_support, gdb_osabi_available_names,

This does the opposite of what the log comment says.  Is the patch
below correct?

2003-11-03  Jim Blandy  <jimb@redhat.com>

	* osabi.c (_initialize_gdb_osabi): Don't return before registering
	the 'set osabi' and 'show osabi' commands.

Index: gdb/osabi.c
===================================================================
RCS file: /cvs/src/src/gdb/osabi.c,v
retrieving revision 1.21
diff -c -r1.21 osabi.c
*** gdb/osabi.c	27 Oct 2003 16:18:23 -0000	1.21
--- gdb/osabi.c	3 Nov 2003 22:08:39 -0000
***************
*** 593,600 ****
  				  bfd_target_elf_flavour,
  				  generic_elf_osabi_sniffer);
  
-   return;
- 
    /* Register the "set osabi" command.  */
    c = add_set_enum_cmd ("osabi", class_support, gdb_osabi_available_names,
  			&set_osabi_string, "Set OS ABI of target.", &setlist);
--- 593,598 ----


             reply	other threads:[~2003-11-03 22:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-03 22:09 Jim Blandy [this message]
2003-11-04  0:02 ` Andrew Cagney
2003-11-04  0:02 ` Richard Earnshaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt21xspumte.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox