From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28254 invoked by alias); 3 Nov 2003 22:09:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28189 invoked from network); 3 Nov 2003 22:09:36 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 3 Nov 2003 22:09:36 -0000 Received: by zenia.home (Postfix, from userid 5433) id D7B66207B3; Mon, 3 Nov 2003 17:09:01 -0500 (EST) To: gdb-patches@sources.redhat.com Subject: RFA: Misapplied patch to _initialize_gdb_osabi? From: Jim Blandy Date: Mon, 03 Nov 2003 22:09:00 -0000 Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00038.txt.bz2 CVS says that revision 1.17 to gdb/osabi.c (ChangeLog entry attached) made the following change: 2003-08-24 Andrew Cagney * arm-tdep.c (_initialize_arm_tdep): Simplify by assuming GDB_MULTI_ARCH is always non-zero. * osabi.c (_initialize_gdb_osabi): Ditto. (gdbarch_init_osabi): Ditto. * sparc-tdep.c: Ditto for #if code. *************** *** 571,578 **** bfd_target_elf_flavour, generic_elf_osabi_sniffer); ! if (!GDB_MULTI_ARCH) ! return; /* Register the "set osabi" command. */ c = add_set_enum_cmd ("osabi", class_support, gdb_osabi_available_names, --- 567,573 ---- bfd_target_elf_flavour, generic_elf_osabi_sniffer); ! return; /* Register the "set osabi" command. */ c = add_set_enum_cmd ("osabi", class_support, gdb_osabi_available_names, This does the opposite of what the log comment says. Is the patch below correct? 2003-11-03 Jim Blandy * osabi.c (_initialize_gdb_osabi): Don't return before registering the 'set osabi' and 'show osabi' commands. Index: gdb/osabi.c =================================================================== RCS file: /cvs/src/src/gdb/osabi.c,v retrieving revision 1.21 diff -c -r1.21 osabi.c *** gdb/osabi.c 27 Oct 2003 16:18:23 -0000 1.21 --- gdb/osabi.c 3 Nov 2003 22:08:39 -0000 *************** *** 593,600 **** bfd_target_elf_flavour, generic_elf_osabi_sniffer); - return; - /* Register the "set osabi" command. */ c = add_set_enum_cmd ("osabi", class_support, gdb_osabi_available_names, &set_osabi_string, "Set OS ABI of target.", &setlist); --- 593,598 ----