From: Eli Zaretskii <eliz@gnu.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: drow@false.org, gdb-patches@sourceware.org
Subject: Re: [rfc] Delay deletion of step-resume breakpoints
Date: Tue, 14 Aug 2007 03:12:00 -0000 [thread overview]
Message-ID: <uzm0udd31.fsf@gnu.org> (raw)
In-Reply-To: <200708132113.l7DLDWEw021526@brahms.sibelius.xs4all.nl> (message from Mark Kettenis on Mon, 13 Aug 2007 23:13:32 +0200 (CEST))
> Date: Mon, 13 Aug 2007 23:13:32 +0200 (CEST)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> CC: gdb-patches@sourceware.org
>
> > /* NOTE: this will take care of any left-over step_resume breakpoints,
> > - but not any user-specified thread-specific breakpoints. */
> > + but not any user-specified thread-specific breakpoints. We can not
> > + delete the breakpoint straight-off, because the inferior might not
> > + be stopped at the moment. */
>
> Makes me suspect this is just a workaround for another bug, the bug
> being that the inferior isn't properly stopped when this code gets
> called.
Actually, I think that's TRT to do in _all_ cases: we are scheduling a
breakpoint delete the next time GDB is in a predictable state to do
that.
That's exactly analogous to what a Posix filesystem does when you
delete a file: if some process has that file open, the file is
scheduled to be deleted when its last handle is closed.
So I think Daniel's patch makes good sense.
next prev parent reply other threads:[~2007-08-14 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 21:03 Daniel Jacobowitz
2007-08-13 21:13 ` Mark Kettenis
2007-08-13 21:37 ` Daniel Jacobowitz
2007-08-27 20:11 ` Daniel Jacobowitz
2007-08-14 3:12 ` Eli Zaretskii [this message]
2007-09-10 21:27 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uzm0udd31.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox