From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Delay deletion of step-resume breakpoints
Date: Mon, 13 Aug 2007 21:13:00 -0000 [thread overview]
Message-ID: <200708132113.l7DLDWEw021526@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20070813210326.GA24049@caradoc.them.org> (message from Daniel Jacobowitz on Mon, 13 Aug 2007 17:03:26 -0400)
> Date: Mon, 13 Aug 2007 17:03:26 -0400
> From: Daniel Jacobowitz <drow@false.org>
>
> The problem with writing a test case is that you need a step resume
> breakpoint in a non-current thread when that thread exits. This is
> timing sensitive and I haven't had any luck reproducing it today.
>
> Does anyone else think this patch is right (or wrong)?
The change you made to the comment:
> /* NOTE: this will take care of any left-over step_resume breakpoints,
> - but not any user-specified thread-specific breakpoints. */
> + but not any user-specified thread-specific breakpoints. We can not
> + delete the breakpoint straight-off, because the inferior might not
> + be stopped at the moment. */
Makes me suspect this is just a workaround for another bug, the bug
being that the inferior isn't properly stopped when this code gets
called.
Mark
next prev parent reply other threads:[~2007-08-13 21:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 21:03 Daniel Jacobowitz
2007-08-13 21:13 ` Mark Kettenis [this message]
2007-08-13 21:37 ` Daniel Jacobowitz
2007-08-27 20:11 ` Daniel Jacobowitz
2007-08-14 3:12 ` Eli Zaretskii
2007-09-10 21:27 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708132113.l7DLDWEw021526@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox