Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Introduce new struct parse_context
Date: Sat, 29 Dec 2007 22:44:00 -0000	[thread overview]
Message-ID: <uve6hw94w.fsf@gnu.org> (raw)
In-Reply-To: <20071226060022.GD28163@adacore.com> (message from Joel Brobecker 	on Tue, 25 Dec 2007 22:00:22 -0800)

> Date: Tue, 25 Dec 2007 22:00:22 -0800
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > > How about the following compromise: I describe again roughly what the
> > > problem is and how I am going to address it. Then you can decide what
> > > to add to gdbint, and where.
> > 
> > Okay, let's try that.
> 
> Great! Here is the problem - It shows up more often on mips-irix.

Thanks for the detailed description.

To document this, I'd go like this:

  Once upon a time, @value{GDBN} used a global variable called
  @code{current_language} to store the current source language.  But
  this didn't always work, because @code{current_language} would
  sometimes get unexpectedly switched under our feet as a side-effect
  of calling functions such as @code{select_frame}.  To resolve this
  difficulty, @value{GDBN} now passes the language as a parameter to
  routines that parse language-specific expressions.

I would then describe the structure that will hold the language and
the input radix, give a few examples of such routines, and explain
when they are used by GDB.  If there's some infrastructure involved
here, beyond the above-mentioned structure, it should be documented as
well.

As to where to document this, I think the node "Language Support" is
the right place.  It already mentions `current_language', so it should
be updated anyway if we are getting rid of that variable.


      reply	other threads:[~2007-12-29 20:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17  7:03 Joel Brobecker
2007-12-17 13:34 ` Daniel Jacobowitz
2007-12-17 20:35 ` Eli Zaretskii
2007-12-21  5:02   ` Joel Brobecker
2007-12-21 16:34     ` Eli Zaretskii
2007-12-22  6:27       ` Joel Brobecker
2007-12-22 17:39         ` Eli Zaretskii
2007-12-26 11:04           ` Joel Brobecker
2007-12-29 22:44             ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uve6hw94w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox