Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: uweigand@de.ibm.com, gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Introduce new struct parse_context
Date: Sat, 22 Dec 2007 06:27:00 -0000	[thread overview]
Message-ID: <20071222062223.GT6154@adacore.com> (raw)
In-Reply-To: <uve6shux5.fsf@gnu.org>

> > If we were to put some documentation in gdbint for this patch,
> > what would you put?
> 
> Both.  This is a significant new feature, and at least its main
> principles should be described in gdbint, enough to get the reader off
> the ground with the knowledge she could use to find the parts of code
> which implement this feature (and read the comments there ;-).

I don't see what you would describe in the documentation that would
not be in the code as a comment. I think I don't see what to say because
I don't see this patch as a significant new feature, but as a modification
whose purpose is to fix a bug (the parser uses the global current_language)
to do the parsing, but this global gets overwritten as a side effect of
a function called between the moment we set the current_language and
the moment we actually do the parsing).

How about the following compromise: I describe again roughly what the
problem is and how I am going to address it. Then you can decide what
to add to gdbint, and where. I would appreciate your help in writing
that addition, because I just simply suck in writing documentations,
and as a result, I'm really slow.  Just the time it takes me to write
good comments makes me mad, sometimes.

-- 
Joel


  reply	other threads:[~2007-12-22  6:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17  7:03 Joel Brobecker
2007-12-17 13:34 ` Daniel Jacobowitz
2007-12-17 20:35 ` Eli Zaretskii
2007-12-21  5:02   ` Joel Brobecker
2007-12-21 16:34     ` Eli Zaretskii
2007-12-22  6:27       ` Joel Brobecker [this message]
2007-12-22 17:39         ` Eli Zaretskii
2007-12-26 11:04           ` Joel Brobecker
2007-12-29 22:44             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071222062223.GT6154@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox