From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Support for multiple calling conventions, patch 3/3: Use calling convention information to handle differnt ABIs on sh target
Date: Tue, 22 Apr 2008 06:30:00 -0000 [thread overview]
Message-ID: <uve2aa7xy.fsf@gnu.org> (raw)
In-Reply-To: <20080421200051.GB23852@calimero.vinschen.de>
> Date: Mon, 21 Apr 2008 22:00:51 +0200
> From: Corinna Vinschen <vinschen@redhat.com>
>
> Thanks for the review. Is that better?
Yes, thanks. I have only two comment now:
> +@kindex set sh calling-convention @var{convention}
The @kindex entry should only mention the command, not its arguments.
So please drop the "@var{convention}" part.
> "@cindex set SH Calling convention
And this index entry is now redundant: the @kindex one will serve the
same purpose.
> +@kindex show sh calling-convention
> +@cindex show SH Calling convention
Same here.
next prev parent reply other threads:[~2008-04-22 3:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 12:44 Corinna Vinschen
2008-04-17 16:36 ` Daniel Jacobowitz
2008-04-21 15:42 ` Corinna Vinschen
2008-04-21 18:18 ` Corinna Vinschen
2008-04-21 20:01 ` Eli Zaretskii
2008-04-21 20:23 ` Corinna Vinschen
2008-04-22 6:55 ` Eli Zaretskii
2008-04-21 20:01 ` Eli Zaretskii
2008-04-21 20:20 ` Corinna Vinschen
2008-04-22 6:30 ` Eli Zaretskii [this message]
2008-04-22 13:54 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uve2aa7xy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox