From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31012 invoked by alias); 22 Apr 2008 03:24:21 -0000 Received: (qmail 31001 invoked by uid 22791); 22 Apr 2008 03:24:21 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 22 Apr 2008 03:24:01 +0000 Received: from HOME-C4E4A596F7 ([83.130.1.82]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0JZP00LSQJFDDW10@i-mtaout6.012.net.il> for gdb-patches@sourceware.org; Tue, 22 Apr 2008 06:38:01 +0300 (IDT) Date: Tue, 22 Apr 2008 06:30:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] Support for multiple calling conventions, patch 3/3: Use calling convention information to handle differnt ABIs on sh target In-reply-to: <20080421200051.GB23852@calimero.vinschen.de> X-012-Sender: halo1@inter.net.il To: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <20080415115840.GA22994@calimero.vinschen.de> <20080417162802.GI17488@caradoc.them.org> <20080421153008.GV23852@calimero.vinschen.de> <20080421200051.GB23852@calimero.vinschen.de> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00461.txt.bz2 > Date: Mon, 21 Apr 2008 22:00:51 +0200 > From: Corinna Vinschen > > Thanks for the review. Is that better? Yes, thanks. I have only two comment now: > +@kindex set sh calling-convention @var{convention} The @kindex entry should only mention the command, not its arguments. So please drop the "@var{convention}" part. > "@cindex set SH Calling convention And this index entry is now redundant: the @kindex one will serve the same purpose. > +@kindex show sh calling-convention > +@cindex show SH Calling convention Same here.