Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com
Subject: Re: [rfc] [01/12] Get rid of current_gdbarch in aix-thread.c
Date: Fri, 03 Aug 2007 12:48:00 -0000	[thread overview]
Message-ID: <utzrgbx8p.fsf@gnu.org> (raw)
In-Reply-To: <46B31B17.6070204@de.ibm.com> (message from Markus Deuling on 	Fri, 03 Aug 2007 14:09:59 +0200)

> Date: Fri, 03 Aug 2007 14:09:59 +0200
> From: Markus Deuling <deuling@de.ibm.com>
> 
> this patch gets rid of some of the current_gdbarch's in aix-thread.c

Thanks!

> Is this ok to commit?

I have a minor nit with the way you describe the changes in the
ChangeLog:

> 	* aix-thread.c (supply_gprs64, supply_fprs, supply_sprs64)
> 	(supply_sprs32, fetch_regs_user_thread, fetch_regs_kernel_thread)
> 	(fill_gprs64, fill_gprs32, fill_fprs, fill_sprs64, fill_sprs32)
> 	(store_regs_user_thread, store_regs_kernel_thread): Use FRAME or
> 	REGCACHE to recognize current architecture.

What are FRAME and REGCACHE here?  They are not variables nor macros
seen in the patches.


  reply	other threads:[~2007-08-03 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-03 12:11 Markus Deuling
2007-08-03 12:48 ` Eli Zaretskii [this message]
2007-08-03 13:03   ` Markus Deuling
2007-08-03 13:26     ` Eli Zaretskii
2007-08-06  8:07       ` Markus Deuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=utzrgbx8p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox