From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23396 invoked by alias); 3 Aug 2007 12:48:02 -0000 Received: (qmail 23364 invoked by uid 22791); 3 Aug 2007 12:48:00 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 12:47:57 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-197-78.inter.net.il [83.130.197.78]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id INP63273 (AUTH halo1); Fri, 3 Aug 2007 15:47:47 +0300 (IDT) Date: Fri, 03 Aug 2007 12:48:00 -0000 Message-Id: From: Eli Zaretskii To: Markus Deuling CC: gdb-patches@sourceware.org, uweigand@de.ibm.com In-reply-to: <46B31B17.6070204@de.ibm.com> (message from Markus Deuling on Fri, 03 Aug 2007 14:09:59 +0200) Subject: Re: [rfc] [01/12] Get rid of current_gdbarch in aix-thread.c Reply-to: Eli Zaretskii References: <46B31B17.6070204@de.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00048.txt.bz2 > Date: Fri, 03 Aug 2007 14:09:59 +0200 > From: Markus Deuling > > this patch gets rid of some of the current_gdbarch's in aix-thread.c Thanks! > Is this ok to commit? I have a minor nit with the way you describe the changes in the ChangeLog: > * aix-thread.c (supply_gprs64, supply_fprs, supply_sprs64) > (supply_sprs32, fetch_regs_user_thread, fetch_regs_kernel_thread) > (fill_gprs64, fill_gprs32, fill_fprs, fill_sprs64, fill_sprs32) > (store_regs_user_thread, store_regs_kernel_thread): Use FRAME or > REGCACHE to recognize current architecture. What are FRAME and REGCACHE here? They are not variables nor macros seen in the patches.