From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Stepping off breakpoints in non-stop debugging mode (resubmit)
Date: Thu, 10 Apr 2008 20:12:00 -0000 [thread overview]
Message-ID: <utzi9a3az.fsf@gnu.org> (raw)
In-Reply-To: <200804101149.35438.pedro@codesourcery.com>
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Thu, 10 Apr 2008 11:49:35 +0100
>
> How about this?
>
> @kindex maint set can-use-displaced-stepping
> @kindex maint show can-use-displaced-stepping
> @cindex displaced stepping support
> @item maint set can-use-displaced-stepping
> @itemx maint show can-use-displaced-stepping
> Control whether or not @value{GDBN} will do displaced stepping if the
> target supports it. The default is on. Displaced stepping is a way
> to single-step over breakpoints without removing them from the
> inferior, by executing an out-of-line copy of the instruction under
> the breakpoint. It is also known as out-of-line single-stepping.
This is okay, but instead of ``under the breakpoint'' I'd suggest to
say ``at the breakpoint location''.
> +Displays the current state of displaying @value{GDBN} displaced stepping
> +debugging info.
This is fine, but I think this is even better:
+Displays the current state of displaying @value{GDBN} debugging
+info related to displaced stepping.
> A couple of typos were also fixed in comments. Updated
> patch attached.
Thanks, approved, with the above gotchas.
next prev parent reply other threads:[~2008-04-10 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 3:14 Pedro Alves
2008-04-10 6:23 ` Eli Zaretskii
2008-04-10 14:02 ` Pedro Alves
2008-04-10 20:12 ` Eli Zaretskii [this message]
2008-04-10 23:13 ` Pedro Alves
2008-04-11 9:15 ` Eli Zaretskii
2008-04-11 15:47 ` Pedro Alves
2008-04-11 16:19 ` Eli Zaretskii
2008-04-11 17:19 ` Pedro Alves
2008-04-11 21:03 ` Eli Zaretskii
2008-04-25 21:51 ` Pedro Alves
2008-04-26 5:47 ` Eli Zaretskii
2008-04-26 7:14 ` Pedro Alves
2008-04-26 13:16 ` Eli Zaretskii
2008-05-02 15:03 ` Daniel Jacobowitz
2008-05-02 17:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=utzi9a3az.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox