From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55081-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2863 invoked by alias); 10 Apr 2008 20:00:21 -0000
Received: (qmail 2849 invoked by uid 22791); 10 Apr 2008 20:00:20 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 10 Apr 2008 20:00:01 +0000
Received: from HOME-C4E4A596F7 ([80.230.158.193]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0JZ400JAHLJ9PJC2@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Thu, 10 Apr 2008 23:13:57 +0300 (IDT)
Date: Thu, 10 Apr 2008 20:12:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Stepping off breakpoints in non-stop debugging mode (resubmit)
In-reply-to: <200804101149.35438.pedro@codesourcery.com>
X-012-Sender: halo1@inter.net.il
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <utzi9a3az.fsf@gnu.org>
References: <200804100003.05361.pedro@codesourcery.com> <uwsn69zdj.fsf@gnu.org> <200804101149.35438.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-04/txt/msg00205.txt.bz2

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Thu, 10 Apr 2008 11:49:35 +0100
> 
> How about this?
> 
> @kindex maint set can-use-displaced-stepping
> @kindex maint show can-use-displaced-stepping
> @cindex displaced stepping support
> @item maint set can-use-displaced-stepping
> @itemx maint show can-use-displaced-stepping
> Control whether or not @value{GDBN} will do displaced stepping if the
> target supports it.  The default is on.  Displaced stepping is a way
> to single-step over breakpoints without removing them from the
> inferior, by executing an out-of-line copy of the instruction under
> the breakpoint.  It is also known as out-of-line single-stepping.

This is okay, but instead of ``under the breakpoint'' I'd suggest to
say ``at the breakpoint location''.

>  +Displays the current state of displaying @value{GDBN} displaced stepping
>  +debugging info.

This is fine, but I think this is even better:

  +Displays the current state of displaying @value{GDBN} debugging
  +info related to displaced stepping.

> A couple of typos were also fixed in comments.  Updated
> patch attached.

Thanks, approved, with the above gotchas.