From: Eli Zaretskii <eliz@gnu.org>
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Darwin Port (Part 3: macosx-nat.[ch])
Date: Fri, 14 Nov 2008 15:42:00 -0000 [thread overview]
Message-ID: <utzaao807.fsf@gnu.org> (raw)
In-Reply-To: <20081110102656.GA60310@ulanbator.act-europe.fr>
> Date: Mon, 10 Nov 2008 11:26:56 +0100
> From: Tristan Gingold <gingold@adacore.com>
>
> macosx-nat.c:
Thanks. I have the same comments as for darwin-nat.c:
. quite a few instances of dead code ("if (0)" etc.)
. some bare printf calls
. user messages not in _()
. new user options (in _initialize_macosx_inferior) need to be
described in the user manual
prev parent reply other threads:[~2008-11-14 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 14:32 Tristan Gingold
2008-11-10 10:28 ` Tristan Gingold
2008-11-10 10:31 ` Tristan Gingold
2008-11-12 10:14 ` Tristan Gingold
2008-11-12 12:33 ` Tristan Gingold
2008-11-14 15:42 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=utzaao807.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox