From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28186 invoked by alias); 14 Nov 2008 11:36:12 -0000 Received: (qmail 28154 invoked by uid 22791); 14 Nov 2008 11:36:11 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Nov 2008 11:35:30 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KAB00100MTBET00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Fri, 14 Nov 2008 13:37:12 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.205.49]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KAB00DS5MY05T50@i-mtaout1.012.net.il>; Fri, 14 Nov 2008 13:37:12 +0200 (IST) Date: Fri, 14 Nov 2008 15:42:00 -0000 From: Eli Zaretskii Subject: Re: [RFC] Darwin Port (Part 3: macosx-nat.[ch]) In-reply-to: <20081110102656.GA60310@ulanbator.act-europe.fr> X-012-Sender: halo1@inter.net.il To: Tristan Gingold Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <20081110102656.GA60310@ulanbator.act-europe.fr> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00329.txt.bz2 > Date: Mon, 10 Nov 2008 11:26:56 +0100 > From: Tristan Gingold > > macosx-nat.c: Thanks. I have the same comments as for darwin-nat.c: . quite a few instances of dead code ("if (0)" etc.) . some bare printf calls . user messages not in _() . new user options (in _initialize_macosx_inferior) need to be described in the user manual