Re: [New WinCE support] [patch 4/4] The bulk of the code.

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 19 Mar 2007 01:16:15 +0000
> From: Pedro Alves <pedro_alves@portugalmail.pt>
> CC:  gdb-patches@sourceware.org
> 
> > Btw, I see in your patch two instances of strwinerror and two places
> > that call it: one in gdbreplay.c, the other in utils.c.  Why did you
> > need two almost identical functions?
> 
> Well, gdbreplay (a separate application) has some other functionality
> that is copied from gdbserver instead of sharing objects,
> eg: perror_with_name.  I didn't think it was worth it to change
> how it is built for just one function.

Sounds rather unclean to me, but if no one else cares, I won't insist.

> They are not identical, because the gdbserver version only
> cares about UNICODE (Win32 API on Windows CE is only wide).

I saw that (that's why I said ``almost identical''), but the
difference is still very minor, so that a version that suits both
types of usage could be easily written.

> >> The errno values and the windows error codes are not the same.
> >
> > This is not a problem: errno should not be used with any literal
> > values anyway, only with symbolical constants.
> 
> I don't understand what you mean here.

I mean that, since WinCE doesn't have errno.h, you could define error
symbols such as EINTR and EMFILE as appropriate for values returned by
GetLastError.

Thanks for the new patch, I'm happy now.