Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@elta.co.il>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [cplus] Add an entry point for cp-names
Date: Sun, 04 Jan 2004 06:16:00 -0000	[thread overview]
Message-ID: <ur7ygp77z.fsf@elta.co.il> (raw)
In-Reply-To: <20031224223616.GA11606@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 24 Dec 2003 17:36:16 -0500)

> Date: Wed, 24 Dec 2003 17:36:16 -0500
> From: Daniel Jacobowitz <drow@mvista.com>
> 
> 2003-12-24  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* Makefile.in (cp_names_h): New variable.
> 	(cp-names.tab.o, cp-names-main.tab.o): Depend on cp-names.h.

Just a reminder: the *.tab.c files need entries in fnchange.lst to
rename them to *_tab.c.  So these two files will need two additional
lines.

Actually, there's more to this: cp-names_tab.c and cp-names-main_tab.c
map to the same 8+3 DOS name, so they will break the script in
gdb/config/djgpp/djconfig.sh which accounts for renaming of *.tab.c
files (see config.sed for the gory details).  Thus, please consider
some other name for cp-names-main.tab.c, one that doesn't conflict
with cp-names.tab.c.

> +cp-names-main.tab.o: cp-names.tab.c $(safe_ctype_h) $(cp_names_h) \
>  	$(srcdir)/../libiberty/cp-demangle.c
>  	$(CC) -c $(INTERNAL_CFLAGS) -DTEST_CPNAMES \
>  		-o cp-names-main.tab.o cp-names.tab.c

Nitpicking: I find this formatting of continuation lines confusing:
the continuation of the list of prerequisites is indented exactly as
the rule's command, so it looks like the first command in a rule.
(Yes, I know: there are other rules indented like that; if no one
objects, I will reindent them so that commands stand out more
clearly.)


  reply	other threads:[~2004-01-04  6:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-24 22:36 Daniel Jacobowitz
2004-01-04  6:16 ` Eli Zaretskii [this message]
2004-02-09 20:34   ` Daniel Jacobowitz
2004-02-10  6:36     ` Eli Zaretskii
2004-02-29 17:25       ` Daniel Jacobowitz
2004-02-29 18:05         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ur7ygp77z.fsf@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox