From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27090 invoked by alias); 4 Jan 2004 06:16:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27073 invoked from network); 4 Jan 2004 06:16:49 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 4 Jan 2004 06:16:49 -0000 Received: from [207.232.27.5] (helo=WST0054) by monty-python.gnu.org with asmtp (Exim 4.24) id 1Ad2WT-0008Ch-PO; Sun, 04 Jan 2004 02:18:05 -0500 Date: Sun, 04 Jan 2004 06:16:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com In-reply-to: <20031224223616.GA11606@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 24 Dec 2003 17:36:16 -0500) Subject: Re: [cplus] Add an entry point for cp-names Reply-to: Eli Zaretskii References: <20031224223616.GA11606@nevyn.them.org> X-SW-Source: 2004-01/txt/msg00069.txt.bz2 > Date: Wed, 24 Dec 2003 17:36:16 -0500 > From: Daniel Jacobowitz > > 2003-12-24 Daniel Jacobowitz > > * Makefile.in (cp_names_h): New variable. > (cp-names.tab.o, cp-names-main.tab.o): Depend on cp-names.h. Just a reminder: the *.tab.c files need entries in fnchange.lst to rename them to *_tab.c. So these two files will need two additional lines. Actually, there's more to this: cp-names_tab.c and cp-names-main_tab.c map to the same 8+3 DOS name, so they will break the script in gdb/config/djgpp/djconfig.sh which accounts for renaming of *.tab.c files (see config.sed for the gory details). Thus, please consider some other name for cp-names-main.tab.c, one that doesn't conflict with cp-names.tab.c. > +cp-names-main.tab.o: cp-names.tab.c $(safe_ctype_h) $(cp_names_h) \ > $(srcdir)/../libiberty/cp-demangle.c > $(CC) -c $(INTERNAL_CFLAGS) -DTEST_CPNAMES \ > -o cp-names-main.tab.o cp-names.tab.c Nitpicking: I find this formatting of continuation lines confusing: the continuation of the list of prerequisites is indented exactly as the rule's command, so it looks like the first command in a rule. (Yes, I know: there are other rules indented like that; if no one objects, I will reindent them so that commands stand out more clearly.)