From: Eli Zaretskii <eliz@gnu.org>
To: "Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] catch syscall -- try 3 -- Build system, documentation and testcase
Date: Wed, 19 Nov 2008 14:06:00 -0000 [thread overview]
Message-ID: <ur658lkyc.fsf@gnu.org> (raw)
In-Reply-To: <1227044596.5454.47.camel@miki>
> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 18 Nov 2008 19:43:15 -0200
>
> > > +Catchpoint 1 (calling syscall 'close'), 0xffffe424 in __kernel_vsyscall ()
> >
> > I'd prefer
> >
> > Catchpoint 1 (call to syscall 'close')
>
> Right, but can I ask you why? :-)
Because "call to" goes better with "return from". "calling" would go
with "returning".
> > > +(gdb) catch syscall 252
> > > +Catchpoint 1 (syscalls 'exit_group')
> >
> > The translation to a mnemonic name will only happen if the XML file
> > does know about the syscall, right? What if it doesn't?
>
> You mean that I should mention what would happen in this case? I think
> that's already mentioned, am I wrong?
You did, but since the text says that 252 is for the case of unknown
mnemonics, it would be better if the example reflected that case as
well, don't you think?
next prev parent reply other threads:[~2008-11-18 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 20:44 Sérgio Durigan Júnior
2008-11-19 0:44 ` Eli Zaretskii
2008-11-19 12:49 ` Sérgio Durigan Júnior
2008-11-19 14:06 ` Eli Zaretskii [this message]
2008-11-19 14:47 ` Sérgio Durigan Júnior
2008-11-19 19:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ur658lkyc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox