From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60099-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19350 invoked by alias); 18 Nov 2008 22:38:23 -0000
Received: (qmail 19297 invoked by uid 22791); 18 Nov 2008 22:38:22 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 22:37:42 +0000
Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KAJ00A00W8X2F00@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Wed, 19 Nov 2008 00:39:30 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.205.49]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KAJ005EHW9M58E0@i-mtaout7.012.net.il>; Wed, 19 Nov 2008 00:39:30 +0200 (IST)
Date: Wed, 19 Nov 2008 14:06:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 4/4] catch syscall -- try 3 -- Build system,	documentation 	and testcase
In-reply-to: <1227044596.5454.47.camel@miki>
X-012-Sender: halo1@inter.net.il
To: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <ur658lkyc.fsf@gnu.org>
References: <1226987134.5454.37.camel@miki> <uskpols50.fsf@gnu.org> <1227044596.5454.47.camel@miki>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00490.txt.bz2

> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 18 Nov 2008 19:43:15 -0200
> 
> > > +Catchpoint 1 (calling syscall 'close'), 0xffffe424 in __kernel_vsyscall ()
> > 
> > I'd prefer
> > 
> >    Catchpoint 1 (call to syscall 'close')
> 
> Right, but can I ask you why? :-)

Because "call to" goes better with "return from".  "calling" would go
with "returning".

> > > +(gdb) catch syscall 252
> > > +Catchpoint 1 (syscalls 'exit_group')
> > 
> > The translation to a mnemonic name will only happen if the XML file
> > does know about the syscall, right?  What if it doesn't?
> 
> You mean that I should mention what would happen in this case?  I think
> that's already mentioned, am I wrong?

You did, but since the text says that 252 is for the case of unknown
mnemonics, it would be better if the example reflected that case as
well, don't you think?