From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [8/9] multiple locations
Date: Sat, 08 Sep 2007 12:28:00 -0000 [thread overview]
Message-ID: <ups0tqr32.fsf@gnu.org> (raw)
In-Reply-To: <200709081555.00821.vladimir@codesourcery.com> (message from Vladimir Prus on Sat, 8 Sep 2007 15:55:00 +0400)
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 8 Sep 2007 15:55:00 +0400
> Cc: gdb-patches@sources.redhat.com
>
> > > + if (part_of_multiple)
> > > + {
> > > + char buf[30];
> >
> > Why 30? GNU coding standards frown on arbitrary constant sizes.
> >
> > > + sprintf (buf, "%d.%d", b->number, loc_number);
>
> Clearly, '30' is sufficient for 2^32 breakpoints, each having 2^32 locations.
Are we talking only about 32-bit machines?
> I don't think using variable-size buffer is going to have any difference.
I thought more about the lines of xsnprintf or some similar function,
which removes the need to worry about these issues.
next prev parent reply other threads:[~2007-09-08 12:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 22:49 Vladimir Prus
2007-09-07 22:51 ` Vladimir Prus
2007-09-08 11:46 ` Eli Zaretskii
2007-09-08 11:55 ` Vladimir Prus
2007-09-08 12:28 ` Eli Zaretskii [this message]
2007-09-22 19:53 ` Vladimir Prus
2007-09-23 4:13 ` Eli Zaretskii
2007-09-08 13:17 ` Mark Kettenis
2007-11-13 7:15 Nick Roberts
2007-11-13 8:05 ` Vladimir Prus
2007-11-13 8:31 ` Nick Roberts
2007-11-13 8:45 ` Vladimir Prus
2007-11-13 12:38 ` Daniel Jacobowitz
2007-11-13 19:58 ` Vladimir Prus
2007-11-14 19:21 ` Jim Blandy
2007-11-13 22:20 ` Eli Zaretskii
2007-11-13 22:47 ` Joel Brobecker
2007-11-14 6:29 ` Vladimir Prus
2007-11-14 7:06 ` Nick Roberts
2007-11-14 11:58 ` Vladimir Prus
2007-11-14 19:18 ` Nick Roberts
2007-11-14 19:37 ` Joel Brobecker
2007-11-14 19:38 ` Vladimir Prus
2007-11-14 20:42 ` Nick Roberts
2007-11-14 21:17 ` Joel Brobecker
2007-11-15 20:39 ` Vladimir Prus
2007-11-16 20:37 ` Nick Roberts
2007-11-19 2:42 ` Nick Roberts
2007-11-14 18:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ups0tqr32.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox