Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [8/9] multiple locations
Date: Tue, 13 Nov 2007 08:31:00 -0000	[thread overview]
Message-ID: <18233.24808.118388.797786@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200711131105.10906.vladimir@codesourcery.com>

 > > This can break a front end which parses the old output, and this is indeed
 > > the case for Emacs 22.1, which has already been released.
 > 
 > The CLI output was never documented as stable, and using it in frontend
 > is prone to such breakage. 

It still presumably makes sense to avoid such breakage where possible.

 > > Does the (p) add anything useful to the user?  The manual says:
 > > 
 > >       An optional `(p)' suffix marks pending breakpoints
 > > 
 > > Is that not clear from the word PENDING?
 > 
 > No, because if you set breakpoint in a shared library, and that library is
 > unloaded, you have some number in 'address' field, but the breakpoint won't
 > actually fire, and the "(p)" indicates that fact.

OK, but the column you've added this to is "Enb" which refers to whether
the breakpoint is enabled or not.  That is really a yes/no question and
not related to whether the breakpoint is pending.

 > > If it's not needed can we please revert it to the old format?  If it is
 > > needed can we find a format that doesn't break existing parsing?
 > 
 > I personally don't think we should cater for clients that try to use CLI
 > despite that being known as bad idea. 

I think we should generally try to cater for _all_ users of GDB and not
impose requirements on their use of GDB.

 >                                       That said -- do you have any
 > suggestions for an alternative format?

Yes I do.  Instead of:

(gdb) inf bre
Num     Type           Disp Enb  Address    What
1       breakpoint     keep y(p) 0xb7f4ce40 

for an unloaded breakpoint, how about:

(gdb) inf bre
Num     Type                   Disp Enb  Address    What
1       pending breakpoint     keep y    0xb7f4ce40 

which seems the right place to put it, and Emacs will parse this properly
because that's where other breakpoint variants are described, e.g.,


3       hw breakpoint  keep y    0x080485bc in main at myprog.c:75

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2007-11-13  8:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-13  7:15 Nick Roberts
2007-11-13  8:05 ` Vladimir Prus
2007-11-13  8:31   ` Nick Roberts [this message]
2007-11-13  8:45     ` Vladimir Prus
2007-11-13 12:38   ` Daniel Jacobowitz
2007-11-13 19:58     ` Vladimir Prus
2007-11-14 19:21       ` Jim Blandy
2007-11-13 22:20   ` Eli Zaretskii
2007-11-13 22:47     ` Joel Brobecker
2007-11-14  6:29       ` Vladimir Prus
2007-11-14  7:06         ` Nick Roberts
2007-11-14 11:58           ` Vladimir Prus
2007-11-14 19:18             ` Nick Roberts
2007-11-14 19:37               ` Joel Brobecker
2007-11-14 19:38               ` Vladimir Prus
2007-11-14 20:42                 ` Nick Roberts
2007-11-14 21:17                   ` Joel Brobecker
2007-11-15 20:39                   ` Vladimir Prus
2007-11-16 20:37                 ` Nick Roberts
2007-11-19  2:42                 ` Nick Roberts
2007-11-14 18:56         ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2007-09-07 22:49 Vladimir Prus
2007-09-07 22:51 ` Vladimir Prus
2007-09-08 11:46 ` Eli Zaretskii
2007-09-08 11:55   ` Vladimir Prus
2007-09-08 12:28     ` Eli Zaretskii
2007-09-22 19:53   ` Vladimir Prus
2007-09-23  4:13     ` Eli Zaretskii
2007-09-08 13:17 ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18233.24808.118388.797786@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox