Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Multiple process support in gdbserver
Date: Sat, 08 Dec 2007 15:29:00 -0000	[thread overview]
Message-ID: <umyslxvkb.fsf@gnu.org> (raw)
In-Reply-To: <20071207212352.GB32256@caradoc.them.org> (message from Daniel 	Jacobowitz on Fri, 7 Dec 2007 16:23:52 -0500)

> Date: Fri, 7 Dec 2007 16:23:52 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> +@subsubsection Multi-Process Mode for @code{gdbserver}

This subsubsection could benefit from a @cindex entry, since it
describes an important functionality.

> -was compiled with the correct sysroot using @code{--with-system-root}).
> +was compiled with the correct sysroot using @code{--with-sysroot}).

Does this mean the previous wording was just plain wrong, or are you
changing the option's spelling?

> +@item monitor exit
> +Tell gdbserver to exit immediately.  This command should be followed by
> +@code{disconnect} to close the debugging session.  @code{gdbserver} will
> +detach from any attached processes and kill any processes it created.

A short explanation how this is used in multi-process debugging would
be good here.

> +This packet is only available in extended mode.

Suggest a cross-reference to where extended mode is explained.

> @@ -24775,7 +24877,7 @@ return -1 if an error occurs.  @var{path
>  @var{flags} is an integer indicating a mask of open flags
>  (@pxref{Open Flags}), and @var{mode} is an integer indicating a mask
>  of mode bits to use if the file is created (@pxref{mode_t Values}).
> -@xref{open} for details of the open flags and mode values.
> +@ref{open} for details of the open flags and mode values.

@ref does not produce a "see", so the above is wrong.  Why did you
replace @xref in the first place, it looks allright here (except that
you need a comma after the right brace)?

> +* The GDB remote stub, gdbserver, now supports run and attach in
> +extended-remote mode.

Is "extended-remote mode" a known term?  If not, we should probably
explain it, or else replace it with a more plain-language description
of it.

Other that these comments, the documentation patches are approved.

Thanks.


  reply	other threads:[~2007-12-08 11:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-08 10:54 Daniel Jacobowitz
2007-12-08 15:29 ` Eli Zaretskii [this message]
2007-12-08 18:14   ` Daniel Jacobowitz
2007-12-10 15:34     ` Daniel Jacobowitz
2008-01-24  1:50       ` Pedro Alves
2008-01-30  0:55         ` Daniel Jacobowitz
2008-01-30  5:55           ` Eli Zaretskii
2008-01-30 13:18             ` Daniel Jacobowitz
2008-02-14 21:09           ` --multi support for Windows targets (Re: [rfc] Multiple process support in gdbserver) Pedro Alves
2008-02-14 21:15             ` Daniel Jacobowitz
2008-02-14 22:43               ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=umyslxvkb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox