From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23945 invoked by alias); 8 Dec 2007 11:42:02 -0000 Received: (qmail 23931 invoked by uid 22791); 8 Dec 2007 11:42:01 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Dec 2007 11:41:48 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-229-115-66.inter.net.il [84.229.115.66]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id EHT57842 (AUTH halo1); Sat, 8 Dec 2007 13:41:41 +0200 (IST) Date: Sat, 08 Dec 2007 15:29:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: gdb-patches@sourceware.org In-reply-to: <20071207212352.GB32256@caradoc.them.org> (message from Daniel Jacobowitz on Fri, 7 Dec 2007 16:23:52 -0500) Subject: Re: [rfc] Multiple process support in gdbserver Reply-to: Eli Zaretskii References: <20071207212352.GB32256@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00134.txt.bz2 > Date: Fri, 7 Dec 2007 16:23:52 -0500 > From: Daniel Jacobowitz > > +@subsubsection Multi-Process Mode for @code{gdbserver} This subsubsection could benefit from a @cindex entry, since it describes an important functionality. > -was compiled with the correct sysroot using @code{--with-system-root}). > +was compiled with the correct sysroot using @code{--with-sysroot}). Does this mean the previous wording was just plain wrong, or are you changing the option's spelling? > +@item monitor exit > +Tell gdbserver to exit immediately. This command should be followed by > +@code{disconnect} to close the debugging session. @code{gdbserver} will > +detach from any attached processes and kill any processes it created. A short explanation how this is used in multi-process debugging would be good here. > +This packet is only available in extended mode. Suggest a cross-reference to where extended mode is explained. > @@ -24775,7 +24877,7 @@ return -1 if an error occurs. @var{path > @var{flags} is an integer indicating a mask of open flags > (@pxref{Open Flags}), and @var{mode} is an integer indicating a mask > of mode bits to use if the file is created (@pxref{mode_t Values}). > -@xref{open} for details of the open flags and mode values. > +@ref{open} for details of the open flags and mode values. @ref does not produce a "see", so the above is wrong. Why did you replace @xref in the first place, it looks allright here (except that you need a comma after the right brace)? > +* The GDB remote stub, gdbserver, now supports run and attach in > +extended-remote mode. Is "extended-remote mode" a known term? If not, we should probably explain it, or else replace it with a more plain-language description of it. Other that these comments, the documentation patches are approved. Thanks.